schnatterer / smeagol-galore

A git-based wiki featuring markdown, a WYSIWYG Editor, PlantUML, and much more
MIT License
24 stars 5 forks source link

Upgrade to Tomcat 9 #5

Closed schnatterer closed 4 years ago

schnatterer commented 4 years ago

Even the upgrade to the (still supported) Tomcat 8.5 in a9a439310051256b79f0c1a5384ed536e16f544d is not the latest version of 8.5, because the offfical Tomcat image seems to be no longer maintained in an alpine variant. See docker-library/tomcat#158 and docker-library/tomcat#166.

So: We need to switch to a different distro.

A short comparison created with docker-images-size:

For Tomcat 8.5

Or Switch to 9 right away?

The size is one argument for bitnami (because smeagol-galore ist 350MB already). What's more, bitnami already implements security features that are implemented in smeagol-galore's Dockerfile. But Bitnami is probably more experienced in hardening Tomcat. So better rely on them.

Migrating to bitnami image means some changes, though. Path's in the image will change and the Env vars as well. And: Bitnami tomcat 9 runs on JDK 11, which might cause problems with smeagol, CAS and even SCMv2.

drrmitep sh bitnami/tomcat:9.0.31-debian-10-r25 -c 'java --version
openjdk 11.0.6 2020-01-14