search

schneebergerlab / msyd

MIT License
9 stars 0 forks source link

Too many modules? #2

Closed mnshgl0110 closed 2 years ago

mnshgl0110 commented 2 years ago

Hi Leon,

If I understand correctly, the current setup.py would install each module separately. Wont it overpopulate the environment and result in conflicts?

-Manish

lrauschning commented 2 years ago

Hi Manish, sorry for the late reply – for some reason, I didn't receive an email notification on this issue. If I understand [0] correctly, the Extension class is just for compiling C/C++ files as produced by Cython as Python modules and would not overpopulate the environment any more than normal Python modules, but it would be cleaner to move them into a pansr submodule. I've reworked the way setup.py finds the .pyx files in a recent commit, but due to a bug in Cython [1] it's still not as elegant as it could be.

[0] https://docs.python.org/3/distutils/setupscript.html#describing-extension-modules [1] https://github.com/cython/cython/issues/1480

lrauschning commented 2 years ago

Okay, I think now the import structure should be working without any conflicts in with other cigar classes or anything. Let me know if there are still issues! Cheers, Leon