search

schneebergerlab / msyd

MIT License
9 stars 0 forks source link

Import pansyn functions. #3

Closed mnshgl0110 closed 2 years ago

mnshgl0110 commented 2 years ago

Hi Leon,

I think the following would be the typical use case for pansr API:

from pansr.scripts.main import coresyn_from_tsv, crosssyn_from_tsv
coresyn = coresyn_from_tsv('pansr.tsv')
crosssyn = crosssyn_from_tsv("pansr.tsv")
pansyn = mergesyn(coresyn, crosssyn)

Currently, coresyn_from_tsv and crosssyn_from_tsv are in main.py. This makes it a bit difficult to import them. I would suggest that we move all functionality in other files. In the main.py, we only can keep the argument parsing and function calling. What do you think?

Best Manish

lrauschning commented 2 years ago

Hi manish, yes – I tihnk that would make it quite a bit more clean. Now the helper functions in main.py have all been moved to util.py and are just called in main, leaving more space to do proper argument parsing. All the best, Leon