search

schneidermanuel / TwitchLeecher-Dx

Twitch Leecher DX - The Broadcast Downloader
MIT License
112 stars 5 forks source link

Unable to download stream with muted bits, despite MP4 conversion disabled. #7

Closed Lebon14 closed 11 months ago

Lebon14 commented 12 months ago

Hi. I've been trying to download this VOD for a good while now to watch locally later: https://www.twitch.tv/videos/1844237156

The log: TwitchLeecher log 28-08-2023.txt

Tried twice downloading as MP4. Failed. Tried downloading twice as TS. Failed. I'm downloading on a NAS with 17TB of free space.

Looking at the log, it tries to download the unmuted vod and when it stumbles upon something that can't be download because it's muted, it fails outright.

Downloading file 'https://d1m7jfoe9zdc1j.cloudfront.net/30ae6eb63f5904dff200_droosy_38616551931_1070442622/chunked/2736-unmuted.ts' failed!

Imho, if I had the expertise, if I find muted parts, I would download the video and insert silence in the audio and do that until audio comes back. Maybe have an option to force muted/censored VOD like you would actually watch it on Twitch?

Windows 11 x64 (all patched up) Ryzen 9 5900X 64GB DDR4 3600 CL16 RAM EVGA GeForce RTX 3070 Ti 2TB Sabrent Rocket Plus nvme drive

Thanks.

schneidermanuel commented 11 months ago

Ok, I did some investigation and it seems, that this is a twitch bug, because this used to work a few months ago. I don't know if the problem is the muted parts, but I found out the following

When watching the stream vod on twitch.tv and having a look at the network tab of your browser, the files gets downloaded the same way as twitch-leecher does. Sometimes, this fails with error 403 (forbidden.) This does not only happen in TwitchLeecher-DX, this happens also in the Browser image image Once this error occurs, the vod-playback in the browser fails with error 2000 (A network error occured. try again later) image

I will continue to watch this, maybe twitch fixes this anytime soon or I might have to implement something that TwitchLeecher skips this parts.

Lebon14 commented 11 months ago

I will continue to watch this, maybe twitch fixes this anytime soon or I might have to implement something that TwitchLeecher skips this parts.

I think this is the best course of action. I'd insert black frames with text, "Unable to get stream information. This might be because the VOD or clip contains muted audio parts and TwitchLeecher-DX was unable to retrieve the transport stream. Audio and video will resume when sound resumes / unmutes."

schneidermanuel commented 11 months ago

c2a9ef13396f26610b2e88625f800e4b05c3958c adresses this. I will do some cleanup and insert text-frames as @Lebon14 suggested and publish a new version when done. I was able to download the vod's in question with the current build.

Lebon14 commented 11 months ago

Thank you so much! Will update (when the update is out)!