search

schnitzeltony / meta-qt5-extra

OE layer for desktop environments based on Qt5 (KDE KF5+Plasma+Apps / lirios / lxqt / lumina)
MIT License
29 stars 32 forks source link

Qt 5.11 Fixes #42

Closed MaxKrummenacher closed 6 years ago

MaxKrummenacher commented 6 years ago

The cmake function qt5_use_modules was deprecated for quite some time and got finally removed in 5.11.

With Qt 5.11 compile time errors pop up when building lxqt recipes. Obviously some headers do not get explicitly included in the source files and they are no longer implicitely pulled in through other headers.

schnitzeltony commented 6 years ago

I am still using LT Qt 5.9 here so I was not aware. Do you think these changes are compatible with elder Qt or do we need a sumo branch?

MaxKrummenacher commented 6 years ago

Hi

I would expect the patches to be backward compatible and I see no need to branch.

The headers which get additionally included in the sources did exist in previous versions of Qt also. So they will get found and likely will not negatively impact a build.

The use qt5_use_modules CMake construct was deprecated a while ago and the proposed way forward is what is implemented in the patches.

So I expect meta-qt5-extra with these patches to work with Qt 5.9, however I did only compile the patched sources against Qt 5.11, e.g. against meta-qt5 master at bc20e3dcd0176529740beb59ccf1f170b9f828a8.

Max