fix failure of lxqt-archiver do_compile on dunfell

schnitzeltony / meta-qt5-extra

OE layer for desktop environments based on Qt5 (KDE KF5+Plasma+Apps / lirios / lxqt / lumina)

MIT License

29 stars 32 forks source link

fix failure of lxqt-archiver do_compile on dunfell #80

Closed clara-avnet closed 4 years ago

clara-avnet commented 4 years ago

When building lxqt-archiver in a dunfell Yocto setup, the following error is produced:

<build-directory>/tmp/work/core2-32-poky-linux/lxqt-archiver/0.2.0-r0/git/src/core/fr-archive.c:1247:9: error: format not a string literal and no format arguments [-Werror=format-security]
 1247 |         error = g_error_new (G_IO_ERROR, G_IO_ERROR_NOT_FOUND, _("Archive not found"));
      |         ^~~~~

The patch introduced by this PR fixes the compilation error.

schnitzeltony commented 4 years ago

Thanks - odd is that I have no warning in my logs although -Wformat-security is there.

However: Can you please

move the patch to lxqt-archiver instead of files folder
in the recipe remove the FILESEXTRAPATHS_prepend := "${THISDIR}/files:" - it is not necessary

clara-avnet commented 4 years ago

I amended my commit to address these two points.

schnitzeltony commented 4 years ago

FWIW:

reworked commit message and sent your patch upstream [1]
have prepared hardened flags long time ago but it slipped out of my focus [2]... So thanks for bringing this back to me

[1] https://github.com/lxqt/lxqt-archiver/pull/184 [2] https://github.com/schnitzeltony/meta-mortsgna/blob/87ba25887173d30ad7b674513b294c7189930aa5/conf/distro/mortsgna.conf#L127