search

schnitzer-lab / EXTRACT-public

EXTRACT is a tractable and robust automated cell extraction tool for calcium imaging, which extracts the activities of cells as time series from both one-photon and two-photon calcium imaging movies.
MIT License
64 stars 17 forks source link

refactored get_defaults and fixed some typos in readme #31

Closed sg-s closed 1 year ago

sg-s commented 1 year ago

changes to readme

fixed typos.

changes to get_defaults

refactored, eliminated 100+ if statements and other boilerplate code, now uses dynamic fields to parse arguments. i think this is much easier to read

fatihdinc commented 1 year ago

Much appreciated, however I will do a complete write-up here. So, for now, I will not approve this change. Please let me know if you have any more requests after I change the readme file and add the user manual. Thanks!

sg-s commented 1 year ago

@fatihdinc i see about the readme -- would it help if I sent you a separate PR with the refactor of get_defaults ?

fatihdinc commented 1 year ago

Those are still revolving as well!