Update README.md - Githubissues

schnitzer-lab / EXTRACT-public

EXTRACT is a tractable and robust automated cell extraction tool for calcium imaging, which extracts the activities of cells as time series from both one-photon and two-photon calcium imaging movies.

MIT License

64 stars 17 forks source link

Update README.md #54

Closed vijayiyer05 closed 1 month ago

vijayiyer05 commented 1 month ago

Changes for first tutorial only to start a PR:

Replace eyes with File Exchange badge for view link
Add 'Lecture Materials' to target file path for run link
Fix first tutorial link typo ('cell refinement' vs 'starting code')

vijayiyer05 commented 1 month ago

Hi @fatihdinc, I was testing this repo along with Alexis Paez (GH handle: apaezmw) today in preparation for SFN 2024 (Alexis will be leading the booth there).

We noticed the tutorial Open in MATLAB Online links aren't opening to the live scripts as expected. It seems they are missing the Lecture Tutorials parent folder in their paths.

So far, I've updated just the first row. If you like the direction, please let me know w/ a quick comment. Then I can complete the remainder & make this an actual (vs draft) PR.

fatihdinc commented 1 month ago

Hi Vijay, sounds good. Thank you for catching this! Could you finish these (and double check the view links are still working, as they may change after PR requests)? Thank you so much!

vijayiyer05 commented 1 month ago

Hi @fatihdinc, this is ready for review.

✅ View links are all now use the File Exchange badge. ✔️ The Open in MATLAB Online target file links appear corrected in the tutorial table. However, there's an issue with GitHub Open in MATLAB Online badges atm, so they don't work & can't be tested.

As we've discussed separately, suggest to get the Tutorial 1 live script hooked up to File Exchange Open in MATLAB Online for the near term.