search

schnitzer-lab / nwbpkg

Repository for NWB standards and converting imaging data to NWB format.
MIT License
0 stars 0 forks source link

Data type needs to match image masks and activity traces #7

Closed bahanonu closed 4 years ago

bahanonu commented 4 years ago

In add_processed_ophys, the default dataType is hard-coded to uint64, this is not compatible with many cell-extraction methods and should either be changed to single or should directly use the datatype of the input data.

https://github.com/schnitzer-lab/nwb_schnitzer_lab/blob/master/add_processed_ophys.m#L74

Will put a suggested change into https://github.com/schnitzer-lab/nwb_schnitzer_lab/pull/6.

bahanonu commented 4 years ago

@bendichter @IvanSmal Is there a reason why dataType does not support a 'single' datatype? Else currently have to convert masks and traces to 'double', which waste space for most algorithm outputs.

bahanonu commented 4 years ago

This has been fixed, see https://github.com/NeurodataWithoutBorders/matnwb/pull/214.