search

schochastics / netrankr

An R package for network centrality
https://schochastics.github.io/netrankr/
Other
49 stars 4 forks source link

non-unique LICENSE file #10

Closed corybrunson closed 2 years ago

corybrunson commented 2 years ago

Currently the root directory contains two license files: LICENSE and LICENSE.md. The first is cited in DESCRIPTION, but the second was created to address another reviewer's request. I believe CRAN requires and only recognizes the first name, so it would be helpful and possibly necessary to combine these into a single file, named 'LICENSE' but with the content of the Markdown file.

Part of this JOSS review.

schochastics commented 2 years ago

I agree that two license files is not optimal but after looking around a bit, it appears to be standard-ish (See for instance ggplot2). usethis::use_mit_license() also creates these two files.

The LICENSE file is the CRAN standard which, however is not recognized by github, hence the need for the LICENSE.md file.

Hope this clarifies this

corybrunson commented 2 years ago

Hm. It does, thank you. I see plenty of packages with what i believe are standard licenses in LICENSE alone, but you're certainly right that your approach is common.