search

schochastics / netrankr

An R package for network centrality
https://schochastics.github.io/netrankr/
Other
49 stars 4 forks source link

benchmarking code #13

Closed corybrunson closed 2 years ago

corybrunson commented 2 years ago

The benchmarking vignette is compelling (and the availability of approximation methods is impressive), but i am unable to check the results for lack of source code. Certainly the vignette should not itself reproduce this analysis, but i believe the code, or code for a smaller, illustrative benchmarking test, should be included—with the repository if not with the package, e.g. in a folder ignored by the R build.

Part of this JOSS review.

schochastics commented 2 years ago

This is a very good point that I missed. I added replication material in the data-raw folder. This is not the material I used back when I added the vignette (I was oblivious about reproducible code then) but from a more recent project. The results dont change, but I did change the figures in the vignette to reflect the different benchmark dataset.

corybrunson commented 2 years ago

This is great, thank you! I only further request that the benchmarking vignette tell users where to find this script so that they can run and adapt it as needed.