schoeberl / chisel-book

Digital Design with Chisel
752 stars 141 forks source link

Broken link to test benches reference #33

Closed IanBoyanZhang closed 2 years ago

IanBoyanZhang commented 2 years ago

https://github.com/schoeberl/chisel-book/blob/master/chisel-book.tex#L1339

Looks like link reference to test benches is out-of-date.

schoeberl commented 2 years ago

Are you proposing to use a newer version of ScalaTest? It is not broken, or is it?

This is about the ScalaTest version that Chisel 3.4.4 uses (3.0.8). It will be switched to 3.1.4 with Chisel 3.5. Then I should update that reference as well.

Thanks for pointing this out.

Martin

On 30 Dec, 2021, at 23:21, Ian Zhang @.***> wrote:

https://github.com/schoeberl/chisel-book/blob/master/chisel-book.tex#L1339 https://github.com/schoeberl/chisel-book/blob/master/chisel-book.tex#L1339 Looks like link reference to test benches https://github.com/schoeberl/chisel-book/blob/master/chisel-book.tex#L1339 is out-of-date.

— Reply to this email directly, view it on GitHub https://github.com/schoeberl/chisel-book/issues/33, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE63GFEYGJWYVE675NL3Y3UTTLOHANCNFSM5LAMTRFQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.

IanBoyanZhang commented 2 years ago

I would like to take the chance to express my gratitude. I just start learning chisel. I find your book is one of the most organized and updated studying materials available online. Thank you!

I meant the xilinx test benches reference doc url https://www.xilinx.com/support/documentation/sw_manuals/xilinx10/isehelp/ise_c_simulation_test_bench.htm redirects to support doc homepage https://www.xilinx.com/support.html#documentation either the original url has been moved or login required.

Ian

schoeberl commented 2 years ago

Thanks, I've changed the link to a Wikipedia entry, although this is a very thin article.