search

schoeberl / chisel-book

Digital Design with Chisel
752 stars 141 forks source link

Fixed Moore FSM 'puls' to 'pulse' #48

Closed Emoun closed 9 months ago

Emoun commented 9 months ago

The Moore FSM used 'puls' instead of 'pulse'. I fixed the text and the diagram.

I couldn't find a way to update the .graffle file with this change (seems to be a mac tool that is needed), so I reimplemented the figure in tikz. It should be very close to the same size and dimensions as the old diagram, so shouldn't affect the layout much. The font used by the old diagram (liberation sans) is not available in latex, so the default one is used. This makes the figure slightly different from the other diagrams.

If it is accepted as I have done here, other diagrams might need to be updated in the same way for a uniform look. I'm willing to do this if you want.

If the use tikz is not acceptable, the best I can do is provide a new pdf version of 'state-diag-rising-moore' that looks exactly like this diagram but I cannot provide a new .graffle file. (I found a tool that can import .graffle files but not export)

schoeberl commented 9 months ago

Thank you for doing the tikz figure! However, redoing all the figures in tikz is too much. I will stick to graffle for now.

schoeberl commented 9 months ago

OK, deleting the graffle was a bit brutal ;-)