search

schoero / swissqrbill

Swiss QR Bill generation in Node.js and browsers
MIT License
156 stars 29 forks source link

TWINT still not working - related to issue #354 #356

Closed Janine65 closed 2 years ago

Janine65 commented 2 years ago

av1 and av2 are correct filled by RaiseNow.com, but the QRBill is not correct. av1 and av2 are printed, the creator and deptor part are on the third page. The QRCode is correct, means it can be payed by TWINT App. AMC-Mitgliederbeitrag-2022-118.pdf Attached the styleguide of TWINT QR-Billing TWINT QR-Rechnung - Styleguide .pdf and a Payload example: TWINT QR-Rechnung - Payload Beispiel.txt

schoero commented 2 years ago

Thank you for reporting this again. I never used the alternative schemes and did not recognise that they were broken.

I have released a beta version which should definitely fix the rendering issues. You can install it using

npm i swissqrbill@beta

With the new version, the generated QR-Bill should look something like this, which should comply with the specifications:

image

Can you test the new version and confirm that the alternative schemes are now working properly before I release a new stable version?

Janine65 commented 2 years ago

Hi I can test it next Weekend an will give you feedback asap. One correction: the av1 and av2 should not be printed at the end. cheers Janine

schoero commented 2 years ago

One correction: the av1 and av2 should not be printed at the end.

Are you sure about that? I could not find any reference that states this (other than the images in the styleguide that you have referred to, that indicate this). And generally all data, that is present in the QR-Code should also be printed on the QR-Bill.

Other than that, i have found an implementation that renders it exactly like in my previous image of the new version: qr-rechnung.net

Janine65 commented 2 years ago

No. I'm not sure. I will test it next weekend and send it as a test to RaiseNow for verification.

schoero commented 2 years ago

Alright, thank you 👍

Janine65 commented 2 years ago

It looks good now except one thing: There should be the TWINT boarder at the top of the qr-billing... image So I have to add this, correct? No problem, I have it done, but it must be documented, that this boarder has to be done.

schoero commented 2 years ago

Thank you for testing.

The TWINT banner is not a requirement, neither by the QR-Bill specifications, nor by TWINT. As you can read in the first paragraph of the style guide you referenced, it is simply a recommendation to draw attention to the fact that this specific QR bill can be paid with TWINT.

Um Ihre Unterstützer und Mitglieder darauf aufmerksam zu machen, dass die QR-Rechnung auch mit der TWINT App gescannt werden kann, empfehlen wir, unsere TWINT Banner in Ihre Rechnungsvorlage aufzunehmen.

Therefore, I don't think that it has to be documented in this library.

I think the TWINT banner is a good thing and I would definitely include it in my QR-Bills if they where TWINT compatible, but I am not sure if such a functionality should be added to this library, since it is not a part of the QR-Bill specifications.

I'm gonna go ahead and release a new version with these fixes this weekend. I may decide to integrate the banner for a future version.

schoero commented 2 years ago

SwissQRBill v3.1.3 that fixes this issue is now released on npm.