Modify _data to be protected instead of private to allow extending SwissQRBill

schoero / swissqrbill

Swiss QR Bill generation in Node.js and browsers

MIT License

159 stars 29 forks source link

Modify _data to be protected instead of private to allow extending SwissQRBill #368

Closed frenzelr closed 2 years ago

frenzelr commented 2 years ago

Cool and well maintained package!

We would like to use SwissQRBill to print multi-page bills with multiple different QR-bills. For that purpose we want to extend PDF_, this however is currently not possible because _data is private. Would it be possible to make it protected instead?

Merci!

schoero commented 2 years ago

Thank you for your contribution. Your change will be included in the next release.

ringeisen commented 2 years ago

Would it be possible to trigger a release? We would love to use this in our production app as well.

schoero commented 2 years ago

SwissQRBill v3.2.0 containing this change is now released on npm.