search

scholarly-python-package / scholarly

Retrieve author and publication information from Google Scholar in a friendly, Pythonic way without having to worry about CAPTCHAs!
https://scholarly.readthedocs.io/
The Unlicense
1.35k stars 297 forks source link

Fix test_bibtex unit test #395

Open arunkannawadi opened 2 years ago

arunkannawadi commented 2 years ago

Describe the bug The test_bibtex unit test with failing, with a cryptic traceback

Screenshots

======================================================================
FAIL: test_bibtex (test_module.TestScholarly)
Test that we get the BiBTeX entry correctly
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/scholarly/scholarly/test_module.py", line 233, in test_bibtex
    self.assertEqual(result, expected_result.replace("\n        ", "\n"))
AssertionError: '@inp[134 chars]ses.  However, the well-known algorithms suffe[4[71](https://github.com/scholarly-python-package/scholarly/runs/5045402146?check_suite_focus=true#step:8:71) chars]\n\n' != '@inp[134 chars]ses. However, the application to large spatial[457 chars]\n\n'
Diff is 960 characters long. Set self.maxDiff to None to see it.

Desktop (please complete the following information): Github Action

Do you plan on contributing?

dlebedinsky commented 1 month ago

Hello. It has been several months since I opened a pull request to fix this issue. I was just wondering if my PR needs more work before it can be merged, and if so, what it is.

arunkannawadi commented 1 month ago

No, it's just that the development work has slowed down a lot since GS keeps changing its schema too often to be stable. I'll make sure to run the tests again this week.