Closed ltalirz closed 1 year ago
Did you get an error there actually? This is within a try
/except
block, so it should be insensitive to whether we are using fp
before or after the breaking change.
You are right - this excerpt I copied was part of the stack trace (and I incorrectly assumed it was the source of the error), but the actual error was:
File "/.../fp/fp.py", line 24, in get_proxy_list
proxies = [f'{tr_elements[i][0].text_content()}:{tr_elements[i][1].text_content()}' for i in
File "/.../fp/fp.py", line 24, in <listcomp>
proxies = [f'{tr_elements[i][0].text_content()}:{tr_elements[i][1].text_content()}' for i in
IndexError: list index out of range
This was with free-proxy 1.0.2. Upgrading to 1.1.0 fixed the issue
I guess the try/except can also be removed if one requires free-proxy>=1.1.0 .
I hadn't seen this error before. Perhaps it's best to require this. I'd leave the try/except
block as it is for now.
Thanks for the two PRs.
scholarly requires free-proxy >= 1.1.0, see
Fixes #Enter the associated issue number.
Description
Describe your addition briefly to help the reviewers understand your contribution.
Checklist
develop
and notmain
.MaxTriesExceededException
or other exceptions.