scholarly-python-package / scholarly

Retrieve author and publication information from Google Scholar in a friendly, Pythonic way without having to worry about CAPTCHAs!
https://scholarly.readthedocs.io/
The Unlicense
1.29k stars 292 forks source link

Fixed test_bibtex unit test, updated CONTRIBUTING.md #525

Open dlebedinsky opened 7 months ago

dlebedinsky commented 7 months ago

Fixes #395.

Description

the test_bibtex function in the test module was attempting to read a file that did not exist. I updated it to read the real file name, reran the test, and it worked. I also updated CONTRIBUTING.md to address some pitfalls that I ran into when I tried to submit my first pull request yesterday. Hopefully this will prevent other newcomers from making the same mistakes I did!

Checklist

dlebedinsky commented 7 months ago

I just pushed another commit, in which I added a unit test for freeproxy. It is the only proxy I have, and I assume this is the case for many others, so I find it helpful. Do you see it? I assumed I would have to open a separate pull request, but I'm not sure now.