import scholarly
query = scholarly.search_pubs('general relativity')
query = next(query)
filled_query = scholarly.fill(query)
# check if filled_query and query are the same
filled_query is query
Expected behavior
Updating the publication in place is redundant when there is a returned publication. I suggest copying the the publication and updating the copy, so the original publication remains intact. The other option is to make the changes in place and remove the return statement.
Do you plan on contributing?
Your response below will clarify whether the maintainers can expect you to fix the bug you reported.
[x] Yes, I will create a Pull Request with the bugfix, if the maintainers would want that.
Describe the bug Here is the definition of the
fill
method:To Reproduce
Expected behavior Updating the publication in place is redundant when there is a returned publication. I suggest copying the the publication and updating the copy, so the original publication remains intact. The other option is to make the changes in place and remove the return statement.
Do you plan on contributing? Your response below will clarify whether the maintainers can expect you to fix the bug you reported.