search

scholarslab / ivanhoe

http://ivanhoe.scholarslab.org
5 stars 0 forks source link

Style pagination on archive-ivanhoe_game page #255

Closed csbailey5t closed 9 years ago

csbailey5t commented 9 years ago

We need to style the pagination

jennifergrayburn commented 9 years ago

apply infinite scroll to the game archive page

jeremyboggs commented 9 years ago

I'd recommend just styling the pagination for this, unless work is already underway. Infinite scroll on a single game page is somewhat necessary, at least as we currently have it coded, to respond to multiple moves. Since there's no such need on the games browse, I'm not sure infinite scroll is necessary. Besides, I suspect there will be far more moves on a game than games themselves.

jennifergrayburn commented 9 years ago

I took a look at this yesterday and completely agree. The pagination is fixed on my local branch. Planning to come in today to make sure I did it correctly before merging it into develop.

csbailey5t commented 9 years ago

I don't think we'll often run into needing the pagination on the archive-ivanhoe_game view, but I think it is nice to keep it more consistent and use infinite scroll. It's also a trivial, one-minute fix (I have it working on a local branch). The other option would be to set the loop to just show all games.

jennifergrayburn commented 9 years ago

Implement infinite scroll for consistency in bfc167f189031a364e2a5d1f301ed01727a47e09