scholarslab / jefferson-notes

Port of Jefferson's Notes on the State of Virginia iOS app
http://jefferson-notes.herokuapp.com/
0 stars 0 forks source link

1784 page image alignment #93

Open bpasanek opened 9 years ago

bpasanek commented 9 years ago

As said in last: just when I thought I had run out of etc. etc.

The main (probably the only) obvious and embarrassing problem with the app is that the 1784 page images are not properly correlated with the text and the 1787 images. What needs to happen in https://github.com/waynegraham/jefferson-notes/blob/master/lib/assets/pages-correlate-no-sync.csv to get this to work right? -- Or are the calls to the UVa repositiory not grounded in this csv? I'll look more deeply into this now and see if I can understand the Ruby/Rails code

waynegraham commented 9 years ago

The pid field needs to be updated for the earlier edition. Basically find the pages that aren't correct, then find the correct pid from the repository http://search.lib.virginia.edu/catalog/uva-lib:710304/view#openLayer/uva-lib:1195294/2392/1559/0/1/0 and update the value of second uva-lib number.

There's actually no Rails code involved in this; it's all in https://github.com/waynegraham/jefferson-notes/blob/master/lib/tasks/import.rake.

We can sit down and go over that if you like...

bpasanek commented 9 years ago

Actually the 1787 page images are also out of synch in places. Here's an issue in Laws. I was trying to fix a transcription that was not displaying some information. I found it farther down than I expected. The page in in question (in 1787) is 237. It sits in the app next to the text for page 245.

The Query (No XIV) starts out in sync: p. 214 says the text, p. 214 says the 1787 image. But then the image for p. 214 appears again (not lined up with the page break). The image for 215 appears twice. And so on.

The transcription that wasn't displaying right is https://github.com/waynegraham/jefferson-notes/blob/master/lib/assets/transcriptions/transcription_260.html

bpasanek commented 9 years ago

Wayne: just saw you wrote! Thanks.

bpasanek commented 9 years ago

Are you here?

jobrien62 commented 9 years ago

Wayne:

That's what I did--or at least thought I did. I'll check it again, but I was trying to make the pids line up correctly with the identifiers in the repository. John On Sep 26, 2014, at 12:48 PM, Wayne Graham notifications@github.com wrote:

The pid field needs to be updated for the earlier edition. Basically find the pages that aren't correct, then find the correct pid from the repository http://search.lib.virginia.edu/catalog/uva-lib:710304/view#openLayer/uva-lib:1195294/2392/1559/0/1/0 and update the value of second uva-lib number.

There's actually no Rails code involved in this; it's all in https://github.com/waynegraham/jefferson-notes/blob/master/lib/tasks/import.rake.

We can sit down and go over that if you like...

— Reply to this email directly or view it on GitHub.

waynegraham commented 9 years ago

@bpasanek I'm always on github, but I'm not in the office. Sending you all a separate email...