search

scholarslab / prism

Prism is a tool for collective interpretation. It's an ongoing experiment by the Praxis Program at the University of Virginia Scholars' Lab
http://prism.scholarslab.org/
Apache License 2.0
25 stars 15 forks source link

Add ability to delete Prisms #181

Closed jeremyboggs closed 11 years ago

jeremyboggs commented 11 years ago

Users should be able to delete any Prisms they created. This would involve adding a delete button somewhere on the individual Prism (highlight page and/or visualization page). Upon activating that button, the user would then get redirected to a confirmation page asking whether they're sure about deleting. This could remind the user how many folks have highlighted their Prism. Once confirmed, the user would then get redirected to the myPrisms page.

shane-et-al commented 11 years ago

We support deletion at the model level. To support deletion, we'll have to add a new view, links on browse/my prism pages, and a new method in the prism controller that will also ensure that the current user owns the prism to be deleted.

I always forget - did we decide that we'd just toss out all the markings in favor of the rights of the uploader?

walshbr commented 11 years ago

A commit I pushed yesterday - https://github.com/scholarslab/prism/commit/fdc8f1817451ad1315e95d3eb57b48fff065a554 - got rid of the deletion model - it was never updated to the new database setup, so it wouldn't have worked anyway. I believe it was the destroy method. Wayne's opinion was that we don't have time to deal with this and the accompanying authorizations right now, so we should just get rid of the thing entirely for this stage.

cdm6zf commented 11 years ago

This is something to try to add after the May 3rd launch

walshbr commented 11 years ago

I think I can make this happen next week.

On Wed, May 1, 2013 at 5:01 PM, cdm6zf notifications@github.com wrote:

This is something to try to add after the May 3rd launch

— Reply to this email directly or view it on GitHubhttps://github.com/scholarslab/prism/issues/181#issuecomment-17306199 .

Brandon Walsh Ph.D. Candidate Department of English Language and Literature Bryan Hall 219 University of Virginia Charlottesville, VA 22904-4121