scholarslab / prism

Prism is a tool for collective interpretation. It's an ongoing experiment by the Praxis Program at the University of Virginia Scholars' Lab
http://prism.scholarslab.org/
Apache License 2.0
25 stars 15 forks source link

Upgrade OmniAuth Facebook #328

Closed waynegraham closed 8 years ago

waynegraham commented 8 years ago

Facebook GraphAPI is removing support for the Graph API calls < v2.1. The version of facebook-omniauth that is currently in place makes calls to the v2.0 API and will no longer work after August 8, 2016. I think this should be just as easy as upgrading the gem (it's currently at v3.0.0) and updating the callback in the initializers (http://www.rubydoc.info/gems/omniauth-facebook/3.0.0).

The other (easier) option is to just remove support for Facebook authentication...

walshbr commented 8 years ago

Haven't looked in detail, but it looks like upgrading facebook-omniauth will also require upgrading omni-auth-oauth2 as a dependency. Which would probably involve tweaks to the other omniauth logins as well:

From my bundler just now:

Bundler could not find compatible versions for gem "omniauth-oauth2": In snapshot (Gemfile.lock): omniauth-oauth2 (= 1.1.2)

In Gemfile: omniauth-oauth2 (~> 1.1.2)

omniauth-facebook (~> 3.0.0) was resolved to 3.0.0, which depends on
  omniauth-oauth2 (~> 1.2)

omniauth-google-oauth2 was resolved to 0.2.8, which depends on
  omniauth-oauth2 (>= 1.1.1)

Running bundle update will rebuild your snapshot from scratch, using only the gems in your Gemfile, which may resolve the conflict.

walshbr commented 8 years ago

Check back in August 8th to make sure that it outlasts the old facebook API being deprecated.

walshbr commented 8 years ago

Yep - still working.

erochest commented 8 years ago

Thank you for checking!