search

schollii / pypubsub

A Python publish-subcribe library (moved here from SourceForge.net where I had it for many years)
194 stars 29 forks source link

Fix deprication warning about using getargspec #18

Closed artizirk closed 5 years ago

artizirk commented 5 years ago

This will silence quite a lot of DepricationWarning messages when running pytest

https://docs.python.org/3/library/inspect.html#inspect.getargspec

pypubsub/src/pubsub/core/callables.py:147: DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec()
paddymccrudden commented 5 years ago

I just noticed this. It would be good to pull this branch to avoid this warning. Thanks for commiting!

paddymccrudden commented 5 years ago

Thanks. What is the process for publishing to the pip installer?

schollii commented 5 years ago

There has to be a sufficient number of improvement to justify this, and all tox tests must pass, and all examples must work. I'm really trying to set time aside to complete PR #13 (https://github.com/schollii/pypubsub/pull/13 -- some tests fail), confirm that everything works with Python 3.7, test with latest wxPython. We can then do another (much needed) patch release.