schollii / pypubsub

A Python publish-subcribe library (moved here from SourceForge.net where I had it for many years)
198 stars 29 forks source link

Support Type hints in listener signatures #25

Closed schollii closed 5 years ago

schollii commented 5 years ago

This is follow-up on #6, which has a PR that cannot be accepted due to test breakage and also seems to be more change than necessary (need investigation). The issue was likely caused by pypubsub use of deprecated inspect.getargspec instead of getargsfullspec. Since this was fixed in another PR, typehints are likely fine and the only portion of #6 that needs addressing is signatures with keyword-only args, to be addressed in #26 due to test failures with PR #13.