search

schollii / pypubsub

A Python publish-subcribe library (moved here from SourceForge.net where I had it for many years)
198 stars 29 forks source link

Update for Python 3.7 #27

Closed schollii closed 5 years ago

schollii commented 5 years ago

Verify no changes needed Update docs

schollii commented 5 years ago

Had to upgrade from inspect.getargspec to signature/Parameter combo. Used @skewty's code from #6, one patch needed for half dozen tests to not fail: looks like signature(func) does not include self if func is a bound method, which is actually the right thing to do, so the line in getArgs that accounts for "self" being present/absent, is no longer needed. This meant a few other lines of code that use getArgs() could be simplified.

The tox only runs from command line, not from PyCharm 2016.3 configuration. Same with Sphinx. The latter likely due to change in API, see https://github.com/sphinx-doc/sphinx/issues/4746.