search

schollii / pypubsub

A Python publish-subcribe library (moved here from SourceForge.net where I had it for many years)
189 stars 29 forks source link

Could you please add a sdist release on Pypi? #48

Open onkelbeh opened 4 years ago

onkelbeh commented 4 years ago

Hello Oliver,

I would like to use PyPubSub-4.0.3 in my Gentoo Overlay for Home Assistant, because the pyinsteon component seems to need it. First, I hope you don't mind. Therefor I need a release file in tar.gz format. It exists at Github, but Pypi only has it in wheel format, currently I use the release file from Github.

Next, I am not sure which name I should choose: The Github repo is called: pypubsub, on Pypi it is called: PyPubSub, but the Pypi Wheel file is: Pypubsub, the library itself installs as pypubsub, the egg calls itself Pypubsub. OK, this works for now, but it could happen that somebody adds it to a repo with one of the other names, this would lead to file collisions in future, perhaps you could clean this up and use one single name on all locations.

Currently I used 'pypubsub' for the ebuild, this avoided all conversions in the build process.

Generally, a tar.gz in sdist format on Pypi is preferred, because this could take use of Gentoo's mirror system. Could you please add one?

Most of the other components/integrations for Home Assistant do both.

Thanks \B.

schollii commented 3 years ago

Hi @onkelbeh , thanks for bringing this to my attention, and sorry I have only seen this now, I'm very busy in the cloud containers world and for some reason I don't get email when an issue is posted here. In any case, I can see the issue with the naming, I have to think about that. In particular, I think the PyPI name probably cannot change, and it is customary for the actual import to be all lower case while the "public" name isn't. So off the cough I'd say there should only be 2, PyPubSub as the "public" name on PyPi etc, and pypubsub for the importable package. So the fixes involved would be rename the github repo (have to check if this is possible, if not then it'll have to stay the way it is), but the wheel and egg should be renamed to all lowercase to reflect the package name.

This is already a few weeks ago, how have you been managing since?

The sdist part is easy.

onkelbeh commented 3 years ago

Currently I took the source from Github: https://github.com/onkelbeh/HomeAssistantRepository/blob/master/dev-python/pypubsub/pypubsub-4.0.3.ebuild

This works for now, but in general, a Pypi SDIST Source would be better, it uses Gentoo's mirror system. No big impact, only one component (pyinsteon) needs the library.

njh commented 1 week ago

Another request for you to publish a .tar.gz Source Distribution in Pypi please for 4.0.3. I am looking at packaging the meshtastic CLI for Homebrew - and like Gentoo, it also has a preference for using the source package.

pypubsub is the only one of its dependencies that isn't publishing a .tar.gz in Pypi.

Thanks!

schollii commented 1 week ago

Sure I'll have a look this weekend

njh commented 1 week ago

Thank you!