search

schollz / cowyo

A feature-rich wiki webserver for minimalists :cow: :speech_balloon:
https://cowyo.com/
MIT License
924 stars 67 forks source link

Make cowyo separately mountable #133

Closed DanielHeath closed 6 years ago

DanielHeath commented 6 years ago

I have split everything out. At the time of writing I've done only minimal testing but it seems to work.

Mounting two instances in the same app definitely works (see herdyo example).

schollz commented 6 years ago

@DanielHeath At first glance it seems great! I'd like to look at it further - do you think its ready? Just wondering if you were still working on it. If not, I'll begin the merge.

Also, did you have trouble with anything on it? I'd be happy to lend hands where I can too.

DanielHeath commented 6 years ago

I didn’t want to send too big a change at a time (if only for your sake) so I’m not planning to continue until the first bit goes through.

Everything went surprisingly easily (hooray for compile checks).

I haven’t tested every feature I touched, but it shouldn’t compile if they’ve broken, and the basic functionality definitely works.

schollz commented 6 years ago

Cool, I've gone through it and it looks amazing, as always. As always, THANK YOU. This is such a cool contribution. I really like putting programs into packages, it supports a lot of functionality down the road. Great job!