search

schollz / croc

Easily and securely send things from one computer to another :crocodile: :package:
https://schollz.com/software/croc6
MIT License
26.78k stars 1.07k forks source link

winget integration now requires Microsoft CLA #714

Closed schollz closed 1 month ago

schollz commented 1 month ago

hi croc community!

winget integration was added back in 2023 (https://github.com/schollz/croc/issues/498), as requested by @CodeCubeNeo since it was becoming the official way to get things installed. thanks for bringing the issue and helping with it, especially @sitiom and @jathek.

I think winget integration is working again, except that it looks like there is a new terms of integration requiring me to agree to the microsoft CLA (https://github.com/microsoft/winget-pkgs/pull/155177#issuecomment-2131384583).

reading through the CLA I found that I disagree with this section (screenshot from 05/25/24):

image

is there a way to have winget support without agreeing to Microsoft's CLA?

cc-ing winget other interested parties like @flleeppyy @bitraid

jathek commented 1 month ago

Does "Submission" in this case refer to the code of the PR, not the code of croc?

schollz commented 1 month ago

@jathek good question.

as I understand the agreement, I read it as code of croc. (if its for the code of the PR, then I find myself asking the question of why do they need a CLA to protect autogenerated yaml files?). either way, the ambiguity is also concerning.

jathek commented 1 month ago

I assume they just want to avoid copyright trolls submitting PRs and then claiming rights to code in the winget-pkgs repo. "Project" in this case refers to winget-pkgs, as far as I can tell.

Edit: https://opensource.microsoft.com/program/#program-releasing, emphasis mine

All contributions to a Microsoft-managed open source project must use the Microsoft Contributor License Agreement (CLA). The CLA must be agreed to by all contributors who are not Microsoft Full-time Employees (FTE) or interns prior to the contribution being merged into the project codebase.

I'm pretty sure it's just a general CLA for any code submitted to an open source Microsoft repository, but hopefully someone else can confirm. You can't be the first to wonder about this.

jathek commented 1 month ago

Found a discussion on winget-pkgs that seems to confirm: https://github.com/microsoft/winget-pkgs/discussions/14084#discussioncomment-794372

The commenter denelon is "Product Manager for WinGet" for Microsoft.

schollz commented 1 month ago

Thanks @jathek.

I like that they are responsive to the discussion around the CLA, that makes me feel better.

That question revolves around the Originality of Work which is also a good question but slightly different in my case.

I made a discussion in their repository, I'd appreciate if we can carry over the discussion there to get a more specific answer: https://github.com/microsoft/winget-pkgs/discussions/155182