schollz / find3

High-precision indoor positioning framework, version 3.
https://www.internalpositioning.com/doc
MIT License
4.65k stars 366 forks source link

Add API for deleting single location #56

Closed Thomas499 closed 6 years ago

Thomas499 commented 6 years ago

I noticed there is a way to delete an entire family, but is there a way to delete one particular room? While training, the room mate forgot to close the app out of training phase and walked all over the house for half a day before realizing what he did. The other readings are good I just want to delete one particular room. Ideally, this would be done by clicking something on the dashboard, but a button built into the app would be nice too.

One of my friends built the private server as instructed on the website. He noticed the delete family command deleted the data temporary, but then a few minutes later it was repopulated with the same data that was deleted. - Is the data stored somewhere in cache or is it possible the delete family command only deleted what the a.i. learned?

Does the 10 second timeout happen only during the pull room request or does it also apply during the training phase? I'm ok with training taking longer if it results in more accurate results. I do not want the pull room request to take long though.

Also, does the a.i. progressively get smarter with each calibration? I noticed that one day all the rooms were in the blue then three days later 3 rooms were in red and 4 were in green. I know when it calibrates it keeps 30% of the data separate to run as a test, but still these numbers seem unusual. What even more unusual is that the real results appear to be much less accurate than the numbers produced by the dashboard.

Does the 10 second timeout happen only during the pull room request or does it also apply during the training phase? I'm ok with training taking longer if it results in more accurate results. I do not want the pull room request to take long though.

The original Find app appears to be significantly more accurate currently during real world test. I am wondering if it takes the a.i. a few days to figure out what to prioritize?

The dashboard needs a little work. I have no idea how it is possible to have 0% accuracy on 56 readings. image

Also, the number of data readings stored is always directly below the first character. This look great until you name a room something large. I.e. Beer pong room. Then the number of data readings directly overlap the accuracy readings. image image image image

If I should had made multiple issue reports for each of the issues, let me know. I will be happy to separate them. I just didn't want the system to suspect I was spamming the gethub account by sending multiple issues.

Is there any chance we can expect any neural networking code anytime soon? I am debating on if this is considered a.i. or just computer learning.

schollz commented 6 years ago

@Thomas499 Thanks could you make multiple issues for these? It will be much easier to track them.

schollz commented 6 years ago

Oh, I forgot there is an API already for deleting a single location: https://www.internalpositioning.com/doc/api.md#delete-location

Thomas499 commented 6 years ago

Is there any way to add that feature to the dashboard, or provide documentation on what to include in the URL if you want to delete the room without hard coding an app?

schollz commented 6 years ago

@Thomas499 Certainly it can be added to the dashboard. But you don't need an app to use it - you can just use any terminal or use something like https://www.hurl.it/

Thomas499 commented 6 years ago

I am trying to figure out how to use hurl.it to do this.

image

image

But still the data from location 1.3 is still there

image Looking at the top I see an error message that says there are no predictions, image

but if data was really deleted, why does it say there are 14 data points for location 1.3?

I tried different variations using hurl.it but so far none seem to delete the location 1.3

schollz commented 6 years ago

@Thomas499

You are using hurl.it incorrectly.

You tried to "GET" the dashboard and then add "DELETE ..." as a parameter.

Instead of "GET" use "DELETE". And instead of the dashboard its just "https://cloud.internalpositioning.com/api/v1/location/kttest/1.3".

There are no parameters.