schollz / oooooo

digital tape loops for monome norns, x6.
https://llllllll.co/t/oooooo
MIT License
49 stars 7 forks source link

Input assignment #14

Closed luciusbono closed 3 years ago

luciusbono commented 3 years ago

Adds the following features:

schollz commented 3 years ago

@luciusbono this is absolutely amazing! thank you so much.

it seems to work perfectly, except for the line in 1+2 - its not recording when armed. i think the reason is that params:get("input type")==(1 or 4) for some reason is not hte same as params:get("input type")==1 or params:get("input type")==4. i checked this by adding these print statements when line 1+2 was enabled:

print(params:get("input type")==(1 or 4))
print(params:get("input type")==1 or params:get("input type")==4)

which prints

false
true

could you change those to the longer or-statements? also, i think instead of "line-in 1" you might just do line-in L since it is controlling the left input.

luciusbono commented 3 years ago

You're totally right, not only was that if-logic broken but I noticed that copied a few not operators that meant that the script was likely not flipping into the faster polling rates in some circumstances. Also also switched input labels, I agree that L/R makes more sense.

schollz commented 3 years ago

look awesome! thank you :) :) :)