search

schollz / peerdiscovery

Pure-Go library for cross-platform local peer discovery using UDP multicast :woman: :repeat: :woman:
MIT License
638 stars 55 forks source link

DisableBroadcast property could be dynamic #21

Open kubasiemion opened 3 years ago

kubasiemion commented 3 years ago

Hi, We started using the framework to quickly span multiple nodes for some MPC tests, and we really really like it. It allows us to mostly forget about the network setup. Great work! What would be nice is a little of dynamic management, especially Broadcast and Interval. Or, alternatively, a slightly better restart capability (some go routines like listen() are tricky ). Would you accept such a PR for a review? Cheers!

schollz commented 3 years ago

Hi @kubasiemion I'm happy to accept any PR! Basically if its good for you, its good for me. The only "review" I do is to make sure it still works with croc. Don't worry about changing the API either - if you want to do it, do it and then itll be a v2 release :)