search

scholrly / neo4django

Drop-in Neo4j/Django integration.
GNU General Public License v3.0
357 stars 83 forks source link

Update relationship_tests.py - failing test #209

Closed tonjo closed 10 years ago

tonjo commented 11 years ago

I think I found. With indexed=True on the property being filtered the test fails. Seems like a bug, at last.

PS: Matt, Why I had to manually change the lines that you've corrected? My bad use of github?

mhluongo commented 11 years ago

Re: use of GitHub- yeah, you should've pulled from master before submitting this PR.

I'll look into the rest this evening.

tonjo commented 11 years ago

Better if I do, then? The one thing I didn't understand was how to do it online. Couldn't find a "pull again", should I remove the repo and re-fork? Strange thing was the "compare" told me it was the same, but you've changed it.

On 17 September 2013 18:33, Matt Luongo notifications@github.com wrote:

Re: use of GitHub- yeah, you should've pulled from master before submitting this PR.

I'll look into the rest this evening.

— Reply to this email directly or view it on GitHubhttps://github.com/scholrly/neo4django/pull/209#issuecomment-24602534 .

mhluongo commented 11 years ago

No, the only way to pull like that would be from the command line (or some other client). GitHub isn't perfect ;)

Don't worry about it, when I work on this I'll clean up the commits.

mhluongo commented 10 years ago

Just merged this in. You're right- it does fail when the property is indexed. I'll open (re-open?) the associated issue and take care of it. Thanks for your persistence with this.