Allow nullable fields with "__icontains"

scholrly / neo4django

Drop-in Neo4j/Django integration.

GNU General Public License v3.0

357 stars 83 forks source link

Allow nullable fields with "__icontains" #243

Closed pirhoo closed 10 years ago

pirhoo commented 10 years ago

Hi,

I noticed that when some nodes don't have the property used by "__icontains", the ! that allows nullable property doesn't work properly. It causes a "java.lang.NullPointerException". To avoid that, I added a "HAS" function just before calling the cypher_predicate_from_condition.

Note that it is failing such as the upstream but this patch works.

All the best, Pierre

mhluongo commented 10 years ago

Excellent, thanks!