search

scholzj / terraform-aws-kubernetes

Terraform module for Kubernetes setup on AWS
Apache License 2.0
200 stars 129 forks source link

Why centos? #14

Open den-vasyliev opened 6 years ago

den-vasyliev commented 6 years ago

Hi! Thank you for your effort!

But why centos?

There is lock to centos marketplace ami, so no flexibility + ASG Error: Launching a new EC2 instance. Status Reason: In order to use this AWS Marketplace product you need to accept terms and subscribe. To do so please visit https://aws.amazon.com/marketplace/pp?sku=aw0evgkw8e5c1q413zgy5pjce. Launching EC2 instance failed.

scholzj commented 6 years ago

CentOS closely resembles Red Hat Enterprise Linux which is the de-facto standard for server-side Linux. I think it suites quite well for this kind of project.

What kind of distribution would you prefer? I can make the ID of the AMI image configurable. But the bootstrap scripts are installing the components from RPMs etc. So it would be still limited to only few distributions and I do not plan to test it for anything else than CentOS.

den-vasyliev commented 6 years ago

Thank you, Jakub for explanation!

I going to add some code during my setup (eg. aws_launch_configuration name_prefix instead of name, etc) and in case (or when) of everything will work correctly i will make PR.

Thank you for module!

matt0x6F commented 6 years ago

CentOS closely resembles Red Hat Enterprise Linux which is the de-facto standard for server-side Linux.

It would've been more appropriate to just say you favor CentOS/RHEL rather than to imply there's an actual technical reason why.

Kubernetes and all associated applications will run on nearly any operating system.

scholzj commented 6 years ago

@mattouille Heh? Sorry for not mentioning or supporting your favourite distro. When I started this project, I needed it to work internally within the enterprise I worked for at that time. And since they used RHEL, using CentOS was obvious choice. If they had used Ubuntu or Debian, I would have probably went with that.

Yes, Kubernetes it self can run on many different distros and operating systems. I have never said anything else. But this issue was not opened on Kubernetes repository. It was opened on my repository which simply doesn't support any other distribution. If you want actual technical reasons why this project doesn't support nearly any operating system, it is as I said ... it uses RPM packages to install the components.

If you want, feel free to open a PR which will change this project from using RPMs to using directly the binaries. Than it might work on more distros.