Fixes for Smart Columbus OS deployment

scholzj / terraform-aws-kubernetes

Terraform module for Kubernetes setup on AWS

Apache License 2.0

202 stars 129 forks source link

Fixes for Smart Columbus OS deployment #15

Open kMaiSmith opened 6 years ago

kMaiSmith commented 6 years ago

Two main changes needed to be made to this module to allow for utilising these scripts in our architecture:

A AWS credentials profile needed to be able to be passed to the plugin
the DNS entry for the kubernetes master needs to point to the private ip to let the slaves connect since our master isn't on a public address.

kMaiSmith commented 6 years ago

I didn't realise the extensiveness of the changes the whitespace tool had done, i can have the whitespace re-jiggering undone if desired

scholzj commented 6 years ago

I would't mind the white space changes per-se. But it is quite hard to find the changes you have made to the code. Could you please revert them or post somewhere a diff without them (as a gist or something like that)?

How does the default profile work with people who pass the credentials as environment variables (such as I do)? Will it still work for me?

kMaiSmith commented 6 years ago

Sure thing. You can also tac a ?w=1 onto the end of the url to see only the non whitespace changes (https://blog.github.com/2011-10-21-github-secrets/)

Erokos commented 3 years ago

Hi, is it possible to use this module without a DNS entry? I also want to have the master node in a privete subnet...

scholzj commented 3 years ago

@Erokos I think you can create a private DNS zone and use that. It does not need to be public DNS zone with a public domain etc. But it needs the DNS.