search

scholzj / terraform-aws-kubernetes

Terraform module for Kubernetes setup on AWS
Apache License 2.0
202 stars 129 forks source link

Module does not support configuring Kubernetes multi-master #4

Open guilhermeblanco opened 7 years ago

guilhermeblanco commented 7 years ago

This might be stretching a bit your motivations on your module, but so far this is the easiest module to read (and likely easiest to maintain/improve) from my 2 weeks research for setting up your own Kubernetes cluster.

I went through kops, kube-aws, typhoon, juju, etc. All of them are too biased on how your environment needs to be to setup Kubernetes. Then don't have to be like that. Just as one example, there's no way to setup Kubernetes on a pre-existing AWS subnet.

On this module, things are way different. It does what's supposed to do: setup Kubernetes.

Based on that, it'd be amazing to see multi-master support on this module. That requires more setup, such as independently building an etcd cluster (with ASG), potentially being based of a shared EBS volume.

I'll try to describe more (or potentially expand on having a PR). Besides being in a rush to delivery the new infrastructure in 2-3 weeks, a single master would be ok for a couple months for me, but the company I work for would require a multi-master fairly soon.

scholzj commented 7 years ago

This module is using kubeadm. I like it because of its flexibility and simplicity. But it has some downsides - in particular it doesn't currently support HA masters (see the Limitations).

I will link this issue to kubernetes/kubeadm#261 so that we can track the progress.

bit-herder commented 5 years ago

hey fyi kubeadm now supports multi master. I was going to fork this and figure it out unless someone else already has.

scholzj commented 5 years ago

@bit-herder I'm now using this pretty much only for development and testing. So to be honest with you, I do not really need it and I will probably not have time to implement the multi-master support anytime soon. So if you find some time to look into it and implement it, it would be great if you can open PR to have it merged here or just let me know about it and I can link to your fork. That would be great.

bit-herder commented 5 years ago

ok great. yeah we ended up doing this, if its fine with my team ill clean up the code and PR it for you.