Whitelisting with "trust" button not adding hostname to Whitelist Sources

schomery / popup-blocker

A reliable popup blocker with history

https://webextension.org/listing/popup-blocker.html

Mozilla Public License 2.0

143 stars 37 forks source link

Whitelisting with "trust" button not adding hostname to Whitelist Sources #114

Closed brellaumpixel closed 3 years ago

brellaumpixel commented 3 years ago

Whitelisting any source hostname via "trust" button not working. i.e. When clicking "trust" button the source hostname not being added to whitelist sources

in addon Options have "When 'trust' button is pressed, add hostname to" = Whitelist Sources

Whitelisting a destination works with no problems
Whitelisting a source worked in Version 0.5.1.3 so have currently rolled back to this version
Tested all Versions 0.5.2-0.5.6 and problem exists in all

Using FF v80 on 64bit Win7

brellaumpixel commented 3 years ago

UPDATE: Have done some debug testing and found adding "tabs" to permissions section of manifest.json fixes problem.

Don't know how to implement that on an 'live' (not the addon debugging) version

schomery commented 3 years ago

Thanks for the report. Will get fixed by the next release