search

schomery / popup-blocker

A reliable popup blocker with history
https://webextension.org/listing/popup-blocker.html
Mozilla Public License 2.0
145 stars 35 forks source link

Enable only on certain websites #37

Closed rayman89 closed 7 years ago

rayman89 commented 7 years ago

Would it be possible to make the addon only do it's job when you are on a certain website. So for example on all the rest of the sites it will allow all the popups but on badsite.com it will be active and block popups?

Keith94 commented 7 years ago

Add your host names to the black-list in the settings page.

rayman89 commented 7 years ago

will that auto enable the addon on that pages if i disable it or how does that work? @Keith94

Keith94 commented 7 years ago

Yes. Look under "descriptions" in the settings for how it works:

Comma separated list of host names that popup blocker should only be active on them. This means popup block is disabled on ALL other domains

rayman89 commented 7 years ago

yeah I tried that but the addon still works for all the sites even if I just typed only 1 urls on the blacklist and if I disable the addon, it does not auto enable itself on the blacklisted sites. @Keith94

Keith94 commented 7 years ago

Hmm, did you remember to click on "save settings" afterwards? I just blacklisted one domain 9tensu.com and it only affects that one. Dev @schomery should know more about this.

EDIT: And you're supposed to keep the add-on enabled as well. Only adding to the blacklist should be necessary.

rayman89 commented 7 years ago

I tested blacklisting github and pressing save then reloading this page and the test page http://tools.add0n.com/popup-blocker.html and on the test page the popups keep getting blocked. @Keith94

Keith94 commented 7 years ago

I notice the same behavior, even after removing add0n.com from the whitelist. So it may be a bug. For other domains (e.g. thepiratebay.org) it seems to work fine.

schomery commented 7 years ago

I tested blacklisting github and pressing save then reloading this page and the test page http://tools.add0n.com/popup-blocker.html and on the test page the popups keep getting blocked

tools.add0n.com is an exception to allow users to test the popup blocker.

I notice the same behavior, even after removing add0n.com from the whitelist.

For blacklist mode to work you need to refresh tabs. If it is not working as excepted (considering tools.add0n.com is an exception), please provide details.

rayman89 commented 7 years ago

Seems to be working now. You can close this.,