Open Taomyn opened 6 years ago
Can you provide steps to reproduce this? To test, I cleared all the settings and just added "add0n.com" to the "Whitelist sources". Browsed the FAQs page which opens the top right download links in new browser tabs and they are not being blocked.
Is this on FF?
No I'm using Chrome, as I detailed above.
Can you reproduce this on a public domain?
@Taomyn did you activate the WOT feature manually after reseting the options?
I'm finding it difficult to replicate it with the other sites I have whitelisted, and the example you gave earlier with the FAQ, I cannot find the FAQ you mention. And no, I did not activate the WOT option when I tested a reset.
All I can say is that yesterday (16th) everything was fine and today (17th) it's not and that there was an update to your extension dated yesterday. All I did between the two times is shutdown the laptop and then start it again today.
If there was a simple way to get back to the previous release at least that could eliminate external factors.
The 0.5.0 is a major release and I did many optimizations to improve the performance. One might be buggy that causes this blockage. Although I don't recommend switching to an earlier release, you can still use a local copy of 0.4.2; https://github.com/schomery/popup-blocker/tree/7e6b5d95b2bb7c2270ffca1106b7a104230408de/src
We need to somehow find a way to reproduce this bug. The weird thing is that you still have the WOT enabled in the screenshot you posted.
These are my current settings:
What does clicking the menu icon do because whether it is blue or grey I get the same result:
open chrome://extensions/?id=aefkmifgmaafnojlojpnekbpbmjiiogg in a browser tab and then click on the background page link. Switch to the console tab and let me know if you see any error there.
What does clicking the menu icon do
It is supposed to disable the extension. You shouldn't get any new notification after disabling the extension.
Sorry, nothing is logged in the console
Okay then, let's debug
What do you get in the console
@schomery this is all I saw (I saved the log and pasted the raw format):
common.js:118 (5) ["disqus.com", "github.com", "twitter.com", "add0n.com", "google.com"]0: "disqus.com"1: "github.com"2: "twitter.com"3: "add0n.com"4: "google.com"length: 5__proto__: Array(0) [] "github.com" common.js:118 (5) ["disqus.com", "github.com", "twitter.com", "add0n.com", "google.com"]0: "disqus.com"1: "github.com"2: "twitter.com"3: "add0n.com"4: "google.com"length: 5__proto__: Array(0) [] "intranet.rotarex.com" common.js:118 (5) ["disqus.com", "github.com", "twitter.com", "add0n.com", "google.com"]0: "disqus.com"1: "github.com"2: "twitter.com"3: "add0n.com"4: "google.com"length: 5__proto__: Array(0) [] "intranet.rotarex.com"
Oh, I did get this when I installed the extension:
Oh, I did get this when I installed the extension:
This is not a bug. Ignore it. Do you still have the issue after 0.5.0.4 release?
Just renabled the extension, I can see it's now 0.5.0.4 and it's still doing the same thing
Came in this morning to suddenly find the extension blocking popups from my Intranet pages. Tried to re-add it to the whitelist of sources but it still comes up. If I disable the extension I can finally work.
I run with 64bit Chrome 68.0.3440.106 on Windows 10.