schomery / popup-blocker

A reliable popup blocker with history
https://webextension.org/listing/popup-blocker.html
Mozilla Public License 2.0
145 stars 35 forks source link

0.5.0.2 ignoring whitelisted source #80

Open Taomyn opened 6 years ago

Taomyn commented 6 years ago

Came in this morning to suddenly find the extension blocking popups from my Intranet pages. Tried to re-add it to the whitelist of sources but it still comes up. If I disable the extension I can finally work.

I run with 64bit Chrome 68.0.3440.106 on Windows 10.

Taomyn commented 6 years ago
schomery commented 6 years ago

Can you provide steps to reproduce this? To test, I cleared all the settings and just added "add0n.com" to the "Whitelist sources". Browsed the FAQs page which opens the top right download links in new browser tabs and they are not being blocked.

schomery commented 6 years ago

Is this on FF?

Taomyn commented 6 years ago

No I'm using Chrome, as I detailed above.

clipboard01 clipboard02

schomery commented 6 years ago

Can you reproduce this on a public domain?

schomery commented 6 years ago

@Taomyn did you activate the WOT feature manually after reseting the options?

Taomyn commented 6 years ago

I'm finding it difficult to replicate it with the other sites I have whitelisted, and the example you gave earlier with the FAQ, I cannot find the FAQ you mention. And no, I did not activate the WOT option when I tested a reset.

All I can say is that yesterday (16th) everything was fine and today (17th) it's not and that there was an update to your extension dated yesterday. All I did between the two times is shutdown the laptop and then start it again today.

If there was a simple way to get back to the previous release at least that could eliminate external factors.

schomery commented 6 years ago

The 0.5.0 is a major release and I did many optimizations to improve the performance. One might be buggy that causes this blockage. Although I don't recommend switching to an earlier release, you can still use a local copy of 0.4.2; https://github.com/schomery/popup-blocker/tree/7e6b5d95b2bb7c2270ffca1106b7a104230408de/src

We need to somehow find a way to reproduce this bug. The weird thing is that you still have the WOT enabled in the screenshot you posted.

Taomyn commented 6 years ago

These are my current settings: clipboard03

What does clicking the menu icon do because whether it is blue or grey I get the same result: clipboard05

schomery commented 6 years ago

open chrome://extensions/?id=aefkmifgmaafnojlojpnekbpbmjiiogg in a browser tab and then click on the background page link. Switch to the console tab and let me know if you see any error there.

What does clicking the menu icon do

It is supposed to disable the extension. You shouldn't get any new notification after disabling the extension.

Taomyn commented 6 years ago

Sorry, nothing is logged in the console

schomery commented 6 years ago

Okay then, let's debug

  1. Create a new Chrome profile
  2. Unzip pp.zip in a local directory and then open chrome://extensions in a browser tab and activate the developer mode
  3. Drop the directory into this tab to install the dev version
  4. Open the background page
  5. Add the hostname to the list and load the network page

What do you get in the console

Taomyn commented 6 years ago

@schomery this is all I saw (I saved the log and pasted the raw format): common.js:118 (5) ["disqus.com", "github.com", "twitter.com", "add0n.com", "google.com"]0: "disqus.com"1: "github.com"2: "twitter.com"3: "add0n.com"4: "google.com"length: 5__proto__: Array(0) [] "github.com" common.js:118 (5) ["disqus.com", "github.com", "twitter.com", "add0n.com", "google.com"]0: "disqus.com"1: "github.com"2: "twitter.com"3: "add0n.com"4: "google.com"length: 5__proto__: Array(0) [] "intranet.rotarex.com" common.js:118 (5) ["disqus.com", "github.com", "twitter.com", "add0n.com", "google.com"]0: "disqus.com"1: "github.com"2: "twitter.com"3: "add0n.com"4: "google.com"length: 5__proto__: Array(0) [] "intranet.rotarex.com"

Taomyn commented 6 years ago

Oh, I did get this when I installed the extension:

clipboard01

schomery commented 6 years ago

Oh, I did get this when I installed the extension:

This is not a bug. Ignore it. Do you still have the issue after 0.5.0.4 release?

Taomyn commented 6 years ago

Just renabled the extension, I can see it's now 0.5.0.4 and it's still doing the same thing