search

schomery / privacy-settings

Alter Firefox's built-in privacy settings easily with a toolbar panel
http://firefox.add0n.com/privacy-settings.html
165 stars 24 forks source link

Update zh_TW translations. #113

Closed s8321414 closed 5 years ago

s8321414 commented 5 years ago

I updated zh_TW translations, please review and merge it :smiley:

schomery commented 5 years ago

@s8321414 there are a few mores like https://github.com/schomery/privacy-settings/blob/master/WebExtension/_locales/en/messages.json#L111. Please add them and ping me.

You can also join to https://www.transifex.com/github-7/privacy-settings/dashboard/ to automatically get the updates.

s8321414 commented 5 years ago

Ah OK, I already request zh_TW there, and I will closr this PR.

schomery commented 5 years ago

thanks. let me know when the translation is ready.

s8321414 commented 5 years ago

I should join the zh_TW team first :sweat_smile:

s8321414 commented 5 years ago

And could you sync GitHub and Transifex? I can see zh_TW doesn't have any translated strings on Transifex...

schomery commented 5 years ago

And could you sync GitHub and Transifex

done. If you are not comfortable with "transifex" you can request a new pull merge. Being in "transifex" only helps getting the updating notifications

s8321414 commented 5 years ago

Thank you! :smiley:

s8321414 commented 5 years ago

It seems I also need webstore.txt synced...

schomery commented 5 years ago

I tried, but I got a message that strings do not match. Can you copy and paste each string in the online editor https://www.transifex.com/github-7/privacy-settings/viewstrings/#zh_TW/webstoretxt_1/126014016

s8321414 commented 5 years ago

Done, thank you :smiley: