search

schonacin / android-auth

Android FIDO2 authenticator using CTAP2 via BLE, powered by RxJava3
Apache License 2.0
5 stars 0 forks source link

Notifications #30

Closed schonacin closed 4 years ago

schonacin commented 4 years ago

Some not so nice stuff is still in here like unfinished tests but for a Pull Request which doesn't to the master it seems ok :D

schonacin commented 4 years ago

Some not so nice stuff is still in here like unfinished tests but for a Pull Request which doesn't to the master it seems ok :D

Why even make a PR if it's not to the master? :D There's a lot of added TODOs and WIPs, but the code mostly makes sense to me. Unfortunately I cannot confirm that the notifications work, as the tests fail. So I'm kinda unsure how to deal with this PR

TODO's and WIP's are ok I guess, we just split assembleComponents into different branches because I wasn't the only person working on it anymore. The notification tests are also not automated but were rather for me to check stuff. But it's probably wise to check whether the notifications actually work for you too :D

schonacin commented 4 years ago

Codecov Report

Merging #30 into assemble_components will decrease coverage by 2.85%. The diff coverage is 0.00%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           assemble_components      #30      +/-   ##
=======================================================
- Coverage                29.05%   26.20%   -2.86%     
=======================================================
  Files                       77       78       +1     
  Lines                     1425     1580     +155     
  Branches                    69       77       +8     
=======================================================
  Hits                       414      414              
- Misses                     984     1139     +155     
  Partials                    27       27
Impacted Files Coverage Δ
..._unicorn/android_auth_lib/android/AuthHandler.java 0.00% <0.00%> (ø)
...corn/android_auth_lib/android/FidoAuthService.java 0.00% <0.00%> (ø)
.../android_auth_lib/android/NotificationHandler.java 0.00% <0.00%> (ø)
...roid_auth_lib/android/authentication/AuthInfo.java 0.00% <0.00%> (ø)
...auth_lib/android/authentication/BiometricAuth.java 0.00% <0.00%> (ø)
...corn/android_auth_lib/android/layers/APILayer.java 0.00% <0.00%> (ø)
...rn/android_auth_lib/android/layers/ErrorLayer.java 0.00% <0.00%> (ø)
.../android_auth_lib/android/layers/RequestLayer.java 0.00% <0.00%> (ø)
...android_auth_lib/android/layers/ResponseLayer.java 0.00% <0.00%> (ø)