search

school-CS2103T / pe

0 stars 0 forks source link

Able to go past the edit limit for Inventory #5

Open guowei42 opened 1 year ago

guowei42 commented 1 year ago

To reproduce: Edit an item's stock in inventory to the maximum with editStock 4 c/999999999. Then manually click the + button.

Expected: The upper limit for edit should be respected by the UI as well.

Actual: UI allows to go past the limit that edit allows.

Maximum that edit allows:

image.png

UI allows going past:

image.png

nus-pe-script commented 1 year ago

Team's Response

The restriction is based on the integer max value, hence UI will work as long as value is less than 2147483647. But UG specifies 9 digits to not confuse users. Also this is a case of extreme values that will never be used

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]