search

school-as-code-testing / school-as-code

MIT License
0 stars 0 forks source link

It might be possible to use the default {{ secret.GITHUB_TOKEN }} instead of needing to generate one #10

Closed lpmi-13 closed 2 years ago

lpmi-13 commented 3 years ago

One of the benefits of not including organizations is that the user should already be able to do things in their own repos. I'm still a bit unclear on whether the default read/write scope is just in the repo in which it's being run (since it apparently installs a github app under the hood, and that's what actually gets the token), or whether it's able to do things with other repos.

I'll set some time aside to confirm either way, and we can just stick with the current approach if we have to, but not requiring the user to even do anything with tokens would be a big win in terms of UX.

default github_token permissions

lpmi-13 commented 3 years ago

Depending on how we want to "package" the MVP will determine if we pursue this.

In either case of a template or seed school.yml (a la helm chart) of the new repo is also the learning space, then we CAN use the GITHUB_TOKEN, and we can probably even just invite other people to collaborate on the repo if/when we scale the MVP for multiple learners, so maybe that's the easiest way to go.

lpmi-13 commented 2 years ago

We'll be using the automatically provisioned github token, which expires at the end of the action run, at least for MVP.