search

school-of-data / r-consortium-proposal

Application for https://www.r-consortium.org/projects/call-for-proposals
Other
13 stars 7 forks source link

update to learnr tutorial and small changes #4

Closed pbpearman closed 7 years ago

pbpearman commented 7 years ago

Heidi, I converted the dual_use tutorial to a learnr tutorial and made many small changes. Some of these were to code, others involved text and code annotation. I think it looks pretty good. Please examine and see if this is what you (more or less) had in mind. I note that there are no opportunities for students to interact with this tutorial. What are your thoughts on that? Best, Peter

pbpearman commented 7 years ago

Heidi, can you accept this pull request? Then I will then pull the updated code, and make the change as you request, then generate a new pull request. I have made quite a few other changes that are good and I don't want to lose them by pulling the current version to my local repo. I promise I will get to the issue you pointed out.

pbpearman commented 7 years ago

Can you merge my pull request. Then I will fix the issue you point out.

pbpearman commented 7 years ago

Can you please merge my changes? Then I will re-pull the repo to local and fix the issue you point out.

HeidiSeibold commented 7 years ago

Did you close this on purpose? Not sure I understand what you would like me to do...

pbpearman commented 7 years ago

I think I made a mistake.

pbpearman commented 7 years ago

I think I closed it by mistake. I am hoping that you would merge the changes I made. Then I can pull to update the repo completely, including the changes to the tutorial that were made since I sent the pull request, and then I would make the changes you suggested. Peter