Open Luffitys opened 2 years ago
I am having the same problem! lj92.obj : error LNK2001: unresolved external symbol __builtin_clz
Workaround: I modified lj92.c in my own fork to remove the builtin. Install with: python -mpip install git+https://github.com/wgprojects/PiDNG.git
@wgprojects If no issues are caused by your commits, a pull request would probably be nice. Seems to work good for me though.
I'm not super familiar with PiDNG, I don't feel I'm able to prove it's a good enough fix for a PR. I found a few lj92.c online which were substantially different; it feels like the change was intentional for performance reasons. I'm sure there's a better way to get gcc to use the builtin when it's available and fall back to the looping version...
Workaround: I modified lj92.c in my own fork to remove the builtin. Install with: python -mpip install git+https://github.com/wgprojects/PiDNG.git
Can confirm it worked in my Win10
I did not notice your workaround and created my own, which is also a pull request https://github.com/schoolpost/PiDNG/pull/67
Thanks for cleaning my workaround into an acceptable commit!
Sent from Yahoo Mail on Android
On Mon., 17 Oct. 2022 at 7:00 a.m., Teemu @.***> wrote:
I did not notice your workaround and created my own, which is also a pull request #67
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>
Same error in a clean docker image based on Ubuntu20.04 . Fix the issue by temprory add Python.h by install python3-dev
RUN apt-get install -y python3-dev && \
pip install pidng && \
apt-get remove -y python3-dev && \
apt-get autoremove -y && \
apt-get clean
@schoolpost The current 4.0.9 release on pypi is still broken on Windows. Installing directly from this repo with pip install git+https://github.com/schoolpost/PiDNG.git
works. Would you be able to make a new release on pypi? Thanks in advance!
unfortunately sill broken. it works from the alternate repo. would be nice to merge them
pip install git+https://github.com/schoolpost/PiDNG.git
I was not able to install the latest version of pidng and got the same error as mentioned in this issue using both installation methods below when trying to install pidng
in a Docker image based on python:3.11-slim-bookworm
.
pip install pidng==4.0.9
pip install git+https://github.com/schoolpost/PiDNG.git
But both installation methods work when using python:3.11-bookworm
(not the slim
version) instead.
LOG: