search

schopenhauer / ig-markets

IG Markets API wrapper for Node.js
https://labs.ig.com/sample-apps
26 stars 18 forks source link

ES7 refactor and Async dependency removed #4

Closed DVLP closed 7 years ago

DVLP commented 7 years ago

This my ES7 refactor which I'm using in my project. The API often fails so I added request repeating functionality. The code, especially _request function is simplified a lot. All callbacks have been removed in favour of async/await

DVLP commented 7 years ago

@schopenhauer It would be better to have this on a branch because it relies on ES7 features. It can be in master but only after adding Babel transpiling for compatibility with regular ES5 and ES6 without --harmony flag

schopenhauer commented 7 years ago

@DVLP Thanks a lot for your contribution. Would you be interested to help maintain this module? I would be happy to make you a collaborator on the repo.

DVLP commented 7 years ago

@schopenhauer thanks for adding me! I may be able to contribute to the project on weekends when I'm working on my experimental, news-reading trading bot