search

schorfES / node-lintspaces

A validator for checking different kinds of whitespaces in your files.
https://npmjs.com/package/lintspaces
MIT License
30 stars 17 forks source link

Integration rc and allows you to declare settings in .lintspacesrc #28

Closed alexander-akait closed 8 years ago

alexander-akait commented 8 years ago

https://github.com/dominictarr/rc

schorfES commented 8 years ago

Is there a special need for this kind of configuration? Why not use the .editorconfig?

PR is welcome! ;-)

alexander-akait commented 8 years ago

@schorfES not all options can settable in .editorconfig. Also all popular utilities for lintint support .*rc config file

schorfES commented 8 years ago

Ah okay... You're right. An integration into lintint would also be nice!

I'll try to create an implementation as soon as possible. The settings load process would look like this if both files are configured:

  1. load .lintspacesrc
  2. load .editorconfig

The reason for this is that the editorconfig can contain different settings depending on filetypes and I think this file is more relevant. So editorconfig can overwrite loaded settings from the lintspacesrc. In a second step we can think about the filetype settings into the rc as well...

What do you think?

alexander-akait commented 8 years ago

@schorfES i think it is correctly

schorfES commented 8 years ago

I've added a feature branch "feature/rc-integration " for this. @evilebottnawi please try if the new option rcconfig fits for your purposes.

You may also take a look into the changes 6257a5a7ceea5ab016a1141c6b5b5362b0247a34 and 368812d2c13908c67909982e3ef18d43bde05d0f (Documentation)

If they are okay, i'll merge and release them as soon as possible.

alexander-akait commented 8 years ago

@schorfES sounds good, all perfectly, thanks

localjo commented 8 years ago

Are there any docs on what .lintspacesrc is, and how to use it? It sounds like something that might be useful to me. I'm having trouble getting the .editorconfig file working with node-lintspaces anyway.

schorfES commented 8 years ago

Add a small example configuration into the documentation. I will release this feature in the upcoming week.

schorfES commented 8 years ago

Published a new version 0.4.0 of lintspaces and also a new version of grunt-lintspaces at 0.7.2 at npm.

@AlbertoElias please update gulp-lintspaces. @evanshortiss please update the cli including a new flag for the .rcconfig .lintspacesrc

Thanks in advance to @AlbertoElias and @evanshortiss!!!