search

schorfES / node-lintspaces

A validator for checking different kinds of whitespaces in your files.
https://npmjs.com/package/lintspaces
MIT License
30 stars 17 forks source link

setting dont allow bom #44

Closed gemal closed 3 years ago

gemal commented 6 years ago

would be nice with a setting that would NOT allow BOM in the start of the file

I have a BOM file that just passed though

I ran: `lintspaces --endOfLine 'lf' --newline --trailingspaces --indentation 'tabs' --verbose

testbom.txt testbom.txt`

schorfES commented 6 years ago

Hi @gemal, what CLI did you use and did you set the allowsBOM option to false through that CLI?

gemal commented 6 years ago

I tried both with allowBOM or not using version 0.4.0

should be very easy to reproduce. can you add the testbom.txt file to the tests and they should fail.

How can I help?

schorfES commented 6 years ago

Hi @gemal,

sorry for not responding such a long time. I've created a test setup to check if lintspaces detects your example file correctly. For me this works for spacings and tabs as expected. Can you try that setup for your self too?

testbom.zip

If this also works for you, we may need to dive a bit deeper into the CLI which I didn't test yet.

schorfES commented 6 years ago

Hey @gemal, could you already test the setup from the comment above?

schorfES commented 3 years ago

Closing this for now.