schorschii / FsClock-Android

Fullscreen Clock Screensaver for Android Smartphone, Tablet & TV
GNU General Public License v3.0
90 stars 38 forks source link

Removed leading zero in 12H format #42

Closed bdotq closed 6 months ago

bdotq commented 7 months ago

Burn in prevention didn't move the bottom bar with the battery status and alarm status. Changed mMainView to animate fsclockRootView. Also, for those who prefer 12 hour formatted time. leading zero on the hour can be annoying. Removed the leading zero for 12H time format and fixed text alignment.

schorschii commented 7 months ago

Thanks for your contribution, but the burn-in prevention of the bottom bar is already fixed in 55ba942c381a21b6f11ad7270c274b68ca36aa9e. This commit added a separate logic for the bottom bar to only move on the X axis. Otherwise, the bottom bar could become invisible when moved further downwards (what you did by moving the entire fsclockRootView).

Can you please remove this from your pull request, so that I can merge the fix for the leading zero in 12H format?

bdotq commented 7 months ago

Updated: removed the commit for Burn in prevention using fsclockRootView. Only 12 hour formatting without leading zero now.

schorschii commented 6 months ago

Sorry for the long delay